Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pe: fix certificate table parsing #359

Merged
merged 1 commit into from
Mar 13, 2023
Merged

pe: fix certificate table parsing #359

merged 1 commit into from
Mar 13, 2023

Conversation

baloo
Copy link
Contributor

@baloo baloo commented Mar 10, 2023

There appear to be an off-by-one error in the parsing of the certificate table. This error would occur when the cert table is at the end of the binary.

cc @RaitoBezarius

@baloo
pe: fix certificate table parsing
e1592d9 
There appear to be an off-by-one error in the parsing of the certificate
table. This error would occur when the cert table is at the end of the
binary.
RaitoBezarius
RaitoBezarius approved these changes Mar 11, 2023
View reviewed changes
Copy link
Contributor

@RaitoBezarius RaitoBezarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was definitely a bit overzealous about getting out of index. :>

m4b
m4b approved these changes Mar 13, 2023
View reviewed changes
Copy link
Owner

@m4b m4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you

@m4b m4b merged commit d7e8e29 into m4b:master Mar 13, 2023
@baloo baloo deleted the baloo/certificate-table/fixup-parsing branch March 13, 2023 04:11
@m4b
Copy link
Owner

m4b commented Jun 12, 2023

released in 0.7.0, thank you so much for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

@m4b m4b m4b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baloo @m4b @RaitoBezarius